Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rootless Improvements #65

Merged
merged 1 commit into from
Dec 18, 2023
Merged

Rootless Improvements #65

merged 1 commit into from
Dec 18, 2023

Conversation

samuelattwood
Copy link
Member

  • Adds nonroot tagged image to run as nats user by default
  • Creates the /nsc directory in the Dockerfile with nats:root ownership and group write
    • This should resolve issues with arbitrary run UIDs (such as in OpenShift), as the user can be expected to still belong to GID 0

wallyqs
wallyqs approved these changes Dec 18, 2023
View reviewed changes
Copy link
Member

@wallyqs wallyqs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@samuelattwood samuelattwood merged commit b33b8c7 into main Dec 18, 2023
@sboulkour sboulkour mentioned this pull request Dec 28, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wallyqs wallyqs wallyqs approved these changes

@caleblloyd caleblloyd Awaiting requested review from caleblloyd

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@samuelattwood @wallyqs