Added param options to /healthz endpoint #3326
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mfaizanse
force-pushed
the
health_endpoint_params
branch
from
1ca1656 to
208858c
Compare
3 tasks
kozlovic
requested changes
Aug 4, 2022
There was a problem hiding this comment.
Thank you for your contribution. Would you mind adding a test for the Healthz system changes, probably in test TestServerEventsPingMonitorz()? Also asking @matthiashanel for help reviewing the system event change. It looks ok to me, but would want to make sure.
mfaizanse
force-pushed
the
health_endpoint_params
branch
from
d5ae6c0 to
0134fff
Compare
kozlovic
requested changes
Aug 5, 2022
mfaizanse
force-pushed
the
health_endpoint_params
branch
2 times, most recently
from
07bbc22 to
467a9a2
Compare
kozlovic
requested changes
Aug 8, 2022
server/jetstream_test.go
Outdated
| defer s.Shutdown() | ||
|
|
||
| if s.JetStreamEnabled() { | ||
| t.Fatalf("Expected JetStream to be disbaled") |
There was a problem hiding this comment.
Typo here that causes our checks to fail:
./server/jetstream_test.go:17518:37: "disbaled" is a misspelling of "disabled"
server/jetstream_test.go
Outdated
| @@ -17508,6 +17508,25 @@ func TestJetStreamWorkQueueSourceNamingRestart(t *testing.T) { | |||
| } | |||
| } | |||
|
|
|||
| func TestJetStreamDisabledHealthz(t *testing.T) { | |||
| s := RunRandClientPortServer() | |||
| if config := s.JetStreamConfig(); config != nil { | |||
There was a problem hiding this comment.
Not necessary since you are not configuring a server with JetStream.
mfaizanse
force-pushed
the
health_endpoint_params
branch
from
f6b5c22 to
1634f33
Compare
5 tasks
derekcollison
added a commit
that referenced
this pull request
Sep 1, 2023
Follow up from #4437 content-type fix for v2.9.22, some fixes to the response from `/healthz` for dev: - In #[3326](#4097) it was changed to return 500 status when before we used to return 503 so this changes it back. - Also as part of #3326 we started to return `status_code` in the healthz response (e.g `{"status":"ok","status_code":200}`) so this removes it for http responses just relying on the http header.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #NNNgit pull --rebase origin main)Related to # nats-io/k8s#541
Resolves # The JetStream portion of #2687
Changes proposed in this pull request:
/healthz?js-enabled=trueto return error if JetStream is disabled./healthz?js-server-only=trueto skip checking of JetStream accounts, streams and consumers./cc @nats-io/core