-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds pagination to stream info #3454
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - but let's have Ivan eyeball too. Also feel free to squash.
9824de1
to
8e2aa14
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some changes needed, especially to prevent panic.
Also, it means that all clients would need to be updated to support this pagination options in the StreamInfo() API, right?
8e2aa14
to
8f98b6c
Compare
Yes, the clients need to be updated to be able to leverage pagination. As soon as this is merged I can create PRs (I already have the coding done) for natscli, jsm.go and nats.go (I can probably have a go at Java as well). |
8f98b6c
to
638c2c1
Compare
638c2c1
to
95c1946
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
… list of (matching) subjects for the messages currently in the stream and the number of messages for each subject, using the pagination API for Stream Info (see nats-io/nats-server#3454)
… list of (matching) subjects for the messages currently in the stream and the number of messages for each subject, using the pagination API for Stream Info (see nats-io/nats-server#3454)
… list of (matching) subjects for the messages currently in the stream and the number of messages for each subject, using the pagination API for Stream Info (see nats-io/nats-server#3454)
… list of (matching) subjects for the messages currently in the stream and the number of messages for each subject, using the pagination API for Stream Info (see nats-io/nats-server#3454)
… list of (matching) subjects for the messages currently in the stream and the number of messages for each subject, using the pagination API for Stream Info (see nats-io/nats-server#3454)
… list of (matching) subjects for the messages currently in the stream and the number of messages for each subject, using the pagination API for Stream Info (see nats-io/nats-server#3454)
If a subject filter is specified in the StreamInfoRequest{} option, then all matching subjects will be returned and not be capped to the server limit of 100,000. It is internally using pagination that was added in the server PR: nats-io/nats-server#3454
Resolves #NNN
git pull --rebase origin main
)Resolves #
Changes proposed in this pull request:
/cc @nats-io/core