Add buildinfo flag #6286
Draft
Add buildinfo flag #6286
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alex Bozhenko <alexbozhenko@gmail.com>
alexbozhenko
force-pushed
the
add_buildinfo
branch
from
0312ed4 to
b5fe72d
Compare
alexbozhenko
commented
Dec 20, 2024
| func PrintBuildinfoAndExit() { | ||
| bi, ok := debug.ReadBuildInfo() | ||
| if !ok || bi == nil { | ||
| //nolint:forbidigo |
There was a problem hiding this comment.
@neilalexander ok to ignore like this here?
bruth
requested changes
Dec 20, 2024
| @@ -5676,10 +5676,11 @@ func getDefaultAuthTimeout(tls *tls.Config, tlsTimeout float64) float64 { | |||
| // specific flags. On success, an options structure is returned configured | |||
| // based on the selected flags and/or configuration file. | |||
| // The command line options take precedence to the ones in the configuration file. | |||
| func ConfigureOptions(fs *flag.FlagSet, args []string, printVersion, printHelp, printTLSHelp func()) (*Options, error) { | |||
| func ConfigureOptions(fs *flag.FlagSet, args []string, printVersion, printHelp, printBuildinfo, printTLSHelp func()) (*Options, error) { | |||
There was a problem hiding this comment.
Embedding the NATS server is quite common and since this is a public function, this is a breaking change we don't want to do.
| // ProcessCommandLineArgs takes the command line arguments | ||
| // validating and setting flags for handling in case any | ||
| // sub command was present. | ||
| func ProcessCommandLineArgs(cmd *flag.FlagSet) (showVersion bool, showHelp bool, err error) { | ||
| func ProcessCommandLineArgs(cmd *flag.FlagSet) (showVersion bool, showHelp bool, showBuildinfo bool, err error) { |
There was a problem hiding this comment.
Same as above, this is a breaking change.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This information is already available through
go version -m path/to/binaryBut it will be more convenient to have it available without go installed.
Test plan:
go build .
./nats-server -buildinfo
./nats-server buildinfo
./nats-server --buildinfo
All return:
Signed-off-by: Alex Bozhenko alex@synadia.com