Merge pull request #508 from paoloteti/fix-error-handling

[FIXED] Coverity Scan unchecked return value
nats-io · Jan 24, 2022 · a551fa9 · a551fa9
2 parents debd46d + da9d24b
commit a551fa9
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/src/msg.c b/src/msg.c
@@ -73,7 +73,7 @@ natsMsgHeader_encode(natsBuffer *buf, natsMsg *msg)
     // See explanation in natsMsgHeader_encodedLen()
     if (natsMsg_needsLift(msg))
     {
-        natsBuf_Append(buf, (const char*) msg->hdr, msg->hdrLen);
+        s = natsBuf_Append(buf, (const char*) msg->hdr, msg->hdrLen);
         return NATS_UPDATE_ERR_STACK(s);
     }
 

diff --git a/src/util.c b/src/util.c
@@ -1967,9 +1967,10 @@ nats_ReadFile(natsBuffer **buffer, int initBufSize, const char *fn)
     else if (fclose(f) != 0)
         s = nats_setError(NATS_ERR, "error closing file '%s': '%s", fn, strerror(errno));
 
+    IFOK(s, natsBuf_AppendByte(buf, '\0'));
+
     if (s == NATS_OK)
     {
-        natsBuf_AppendByte(buf, '\0');
         *buffer = buf;
     }
     else if (buf != NULL)