Added test for fix from PR 654 #655
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix was provided by outside contributor. Adding test that demonstrated the issue and ensures that it is now fixed. Signed-off-by: Ivan Kozlovic <ivan@synadia.com>
levb
approved these changes
May 22, 2023
There was a problem hiding this comment.
LGTM.
Before I merge, @kozlovic: OT: this one targets main, whereas some PRs (like my microservices PR) target dev; why the difference? (maybe I just need to go through a release once and then I'll understand the mechanics of what goes where).
|
@levb We push to |
|
@levb This one is ready to merge. Let me know if you need more info regarding main vs dev. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix was provided by outside contributor. Adding test that demonstrated the issue and ensures that it is now fixed.
Signed-off-by: Ivan Kozlovic ivan@synadia.com