-
Notifications
You must be signed in to change notification settings - Fork 685
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ADDED] CreateConsumer and UpdateConsumer methods to work with server 2.10 capabilities #1379
Conversation
Signed-off-by: Piotr Piotrowski <piotr@synadia.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just small nit about the readme still having an example using CreateOrUpdate, otherwise LGTM!
@@ -253,16 +253,25 @@ CRUD operations on consumers can be achieved on 2 levels: | |||
js, _ := jetstream.New(nc) | |||
|
|||
// create a consumer (this is an idempotent operation) | |||
cons, _ := js.CreateOrUpdateConsumer(ctx, "ORDERS", jetstream.ConsumerConfig{ | |||
// an error will be returned if consumer already exists and has different configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should still have an example using CreateOrUpdateConsumer() (since it is still there)
Signed-off-by: Piotr Piotrowski <piotr@synadia.com>
… 2.10 capabilities (#1379) Signed-off-by: Piotr Piotrowski <piotr@synadia.com>
… 2.10 capabilities (#1379) Signed-off-by: Piotr Piotrowski <piotr@synadia.com>
… 2.10 capabilities (#1379) Signed-off-by: Piotr Piotrowski <piotr@synadia.com>
… 2.10 capabilities (#1379) Signed-off-by: Piotr Piotrowski <piotr@synadia.com>
… 2.10 capabilities (#1379) Signed-off-by: Piotr Piotrowski <piotr@synadia.com>
No description provided.