Remove ordered consumer on reset and fix recreated consumer name #1449
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Piotr Piotrowski <piotr@synadia.com>
wallyqs
reviewed
Oct 25, 2023
js.go
Outdated
| if err != nil && !errors.Is(err, ErrConsumerNotFound) { | ||
| var apiErr *APIError | ||
| if errors.Is(err, ErrJetStreamNotEnabled) || errors.Is(err, ErrTimeout) || errors.Is(err, context.DeadlineExceeded) { | ||
| // if creating consumer failed, retry |
There was a problem hiding this comment.
here we abort recreating the ordered consumer if deleting the previous consumer fails? I wonder if we should ignore the delete consumer error but call pushErr here and then proceed to recreate the ordered consumer instead as before
There was a problem hiding this comment.
The delete call should be async and best effort, I would not even wait for a response.
There was a problem hiding this comment.
Good points, done
Signed-off-by: Piotr Piotrowski <piotr@synadia.com>
Closed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Piotr Piotrowski piotr@synadia.com