Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ADDED] Retry PublishAsync on no responders #1464

Merged
merged 2 commits into from
Nov 11, 2023
Merged

Conversation

piotrpio
Copy link
Collaborator

@piotrpio piotrpio commented Nov 9, 2023

Adds retry logic similar to Publish() and PublishMsg() to async counterparts. Previously WithRetryAttempts and WithRetryWait options were ignored.

Fixes #1462

Signed-off-by: Piotr Piotrowski piotr@synadia.com

Signed-off-by: Piotr Piotrowski <piotr@synadia.com>
@piotrpio piotrpio requested a review from Jarema November 9, 2023 14:07
jetstream/options.go Outdated Show resolved Hide resolved
jetstream/options.go Outdated Show resolved Hide resolved
jetstream/publish.go Show resolved Hide resolved
Signed-off-by: Piotr Piotrowski <piotr@synadia.com>
Copy link
Member

@Jarema Jarema left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@piotrpio piotrpio merged commit 5d5844d into main Nov 11, 2023
2 checks passed
@piotrpio piotrpio deleted the retry-in-publish-async branch November 11, 2023 20:30
@piotrpio piotrpio mentioned this pull request Nov 11, 2023
@piotrpio piotrpio mentioned this pull request Jan 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

jetstream.PublishMsgAsync ignores jetstream.WithRetryAttempts and jetstream.WithRetryWait options
2 participants