Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIXED] Invalid checkPending logic #1516

Merged
merged 2 commits into from
Jan 11, 2024
Merged

[FIXED] Invalid checkPending logic #1516

merged 2 commits into from
Jan 11, 2024

Conversation

piotrpio
Copy link
Collaborator

  • fixed invalid condition when s.fetchInProgress was ignored
  • fixed calculating batch size when working with MaxBytes

Signed-off-by: Piotr Piotrowski piotr@synadia.com

@piotrpio piotrpio requested a review from Jarema January 10, 2024 22:45
Signed-off-by: Piotr Piotrowski <piotr@synadia.com>
Signed-off-by: Piotr Piotrowski <piotr@synadia.com>
Copy link
Member

@Jarema Jarema left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@piotrpio piotrpio merged commit 2d90f1f into main Jan 11, 2024
1 of 2 checks passed
@piotrpio piotrpio mentioned this pull request Jan 12, 2024
@piotrpio piotrpio deleted the fix-check-pending branch January 13, 2024 08:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants