[ADDED] TermWithReason method on JetStream message #1539
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Piotr Piotrowski <piotr@synadia.com>
ripienaar
reviewed
Jan 30, 2024
| // the value of MaxDeliver. The provided reason will be included in JetStream | ||
| // advisory event sent by the server. | ||
| // | ||
| // Note: This will only work with JetStream servers >= 2.10.4. |
There was a problem hiding this comment.
would result in a timeout error right since implementation uses ackReply?
There was a problem hiding this comment.
But ackReply does a simple publish on a JS reply subject, it does not wait for server ack (only DoubleAck does that). So it would simply work as if the message was not terminated and will eventually be redelivered.
There was a problem hiding this comment.
Ah, i always get confused with this method name, you're right.
Signed-off-by: Piotr Piotrowski <piotr@synadia.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Piotr Piotrowski piotr@synadia.com