Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IMPROVED] ObjectStore documentation #1551

Merged
merged 2 commits into from
Feb 14, 2024
Merged

[IMPROVED] ObjectStore documentation #1551

merged 2 commits into from
Feb 14, 2024

Conversation

piotrpio
Copy link
Collaborator

@piotrpio piotrpio commented Feb 8, 2024

Signed-off-by: Piotr Piotrowski piotr@synadia.com

@piotrpio piotrpio requested review from Jarema and ripienaar and removed request for ripienaar and Jarema February 8, 2024 18:34
@piotrpio piotrpio marked this pull request as draft February 8, 2024 18:35
Signed-off-by: Piotr Piotrowski <piotr@synadia.com>
@piotrpio piotrpio marked this pull request as ready for review February 9, 2024 10:48
Copy link
Contributor

@ripienaar ripienaar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM minus some questions, I am not knowledgeable on object store though

jetstream/README.md Show resolved Hide resolved
jetstream/object.go Show resolved Hide resolved
Copy link
Member

@Jarema Jarema left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

jetstream/object.go Outdated Show resolved Hide resolved
Co-authored-by: Tomasz Pietrek <tomasz@nats.io>
@piotrpio piotrpio merged commit 62a6489 into main Feb 14, 2024
0 of 2 checks passed
@piotrpio piotrpio deleted the improve-object-docs branch February 14, 2024 07:30
@piotrpio piotrpio mentioned this pull request Feb 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants