[IMPROVED] Performance of respToken #1575
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Piotr Piotrowski <piotr@synadia.com>
Merged
piotrpio
added a commit
that referenced
this pull request
Aug 15, 2024
Signed-off-by: Piotr Piotrowski <piotr@synadia.com>
piotrpio
added a commit
that referenced
this pull request
Aug 15, 2024
Signed-off-by: Piotr Piotrowski <piotr@synadia.com>
piotrpio
added a commit
that referenced
this pull request
Dec 13, 2024
Signed-off-by: Piotr Piotrowski <piotr@synadia.com>
piotrpio
added a commit
that referenced
this pull request
Dec 13, 2024
Signed-off-by: Piotr Piotrowski <piotr@synadia.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using
fmt.Sscanf()in muxer caused performance overhead for each request sent by the client. It is sufficient to only compare the expected inbox prefix with the response subject and grab the token from the end of the subject (as is done in other clients).Benchmark results:
fmt.Sscanf:BenchmarkRespToken-10 2836392 418.7 ns/op 83 B/op 4 allocs/opBenchmarkRespToken-10 408571200 2.837 ns/op 0 B/op 0 allocs/opFixes #1560