Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small improvement to example code in jetstream/README.md #1595

Merged
merged 4 commits into from
Apr 22, 2024
Merged

Conversation

jnmoyne
Copy link
Contributor

@jnmoyne jnmoyne commented Mar 29, 2024

Small improvements to the example code

Signed-off-by: Jean-Noël Moyne <jnmoyne@gmail.com>
Signed-off-by: Jean-Noël Moyne <jnmoyne@gmail.com>
Copy link
Collaborator

@piotrpio piotrpio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just a couple of nits.

jetstream/README.md Outdated Show resolved Hide resolved
jetstream/README.md Outdated Show resolved Hide resolved
Signed-off-by: Jean-Noël Moyne <jnmoyne@gmail.com>
…ars for tab rather than 4 🙄

Signed-off-by: Jean-Noël Moyne <jnmoyne@gmail.com>
@jnmoyne jnmoyne requested a review from piotrpio April 22, 2024 08:37
Copy link
Collaborator

@piotrpio piotrpio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@piotrpio piotrpio merged commit 74ba523 into main Apr 22, 2024
2 checks passed
@piotrpio piotrpio deleted the jnm/29-mar-24 branch April 22, 2024 10:41
piotrpio pushed a commit that referenced this pull request Aug 15, 2024
Signed-off-by: Jean-Noël Moyne <jnmoyne@gmail.com>
piotrpio pushed a commit that referenced this pull request Aug 15, 2024
Signed-off-by: Jean-Noël Moyne <jnmoyne@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants