[FIXED] Call ConnectedCB with RetryOnFailedConnect when initial conn failed #1619
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
piotrpio
force-pushed
the
fix-connected-cb
branch
from
8d178b4 to
f6b111e
Compare
|
I don't think its a breaking change, sure people can depend on this behaviour but it is clearly wrong, so I think its ok to fix the bug imo. |
piotrpio
force-pushed
the
fix-connected-cb
branch
from
5e773e7 to
fd21d11
Compare
Jarema
requested changes
Apr 21, 2024
nats.go
Outdated
| if nc.Opts.ReconnectedCB != nil && !nc.initc { | ||
| nc.ach.push(func() { nc.Opts.ReconnectedCB(nc) }) | ||
| } else if nc.Opts.ConnectedCB != nil && nc.initc { | ||
| fmt.Println() |
…failed Signed-off-by: Piotr Piotrowski <piotr@synadia.com>
Signed-off-by: Piotr Piotrowski <piotr@synadia.com>
Signed-off-by: Piotr Piotrowski <piotr@synadia.com>
piotrpio
force-pushed
the
fix-connected-cb
branch
from
fd21d11 to
23902b7
Compare
Merged
piotrpio
added a commit
that referenced
this pull request
Aug 15, 2024
…failed (#1619) Signed-off-by: Piotr Piotrowski <piotr@synadia.com>
piotrpio
added a commit
that referenced
this pull request
Aug 15, 2024
…failed (#1619) Signed-off-by: Piotr Piotrowski <piotr@synadia.com>
piotrpio
added a commit
that referenced
this pull request
Dec 13, 2024
…failed (#1619) Signed-off-by: Piotr Piotrowski <piotr@synadia.com>
piotrpio
added a commit
that referenced
this pull request
Dec 13, 2024
…failed (#1619) Signed-off-by: Piotr Piotrowski <piotr@synadia.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an issue when
ConnectedCBis not called when using RetryOnFailedConnect and the first attempt to connect fails but subsequent retry is successful.Previously
ReconnectedCBwas invoked in such case.Signed-off-by: Piotr Piotrowski piotr@synadia.com