Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixup MaxAckPending default value comment unit typo #1639

Merged
merged 1 commit into from
May 27, 2024
Merged

Fixup MaxAckPending default value comment unit typo #1639

merged 1 commit into from
May 27, 2024

Conversation

agcom
Copy link
Contributor

@agcom agcom commented May 25, 2024

piotrpio
piotrpio approved these changes May 27, 2024
View reviewed changes
Copy link
Collaborator

@piotrpio piotrpio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you for the contribution!

@piotrpio piotrpio merged commit c93d277 into nats-io:main May 27, 2024
1 check failed
@piotrpio piotrpio mentioned this pull request Jun 14, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@piotrpio piotrpio piotrpio approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@agcom @piotrpio