[FIXED] Remove ConsumerInfo() calls in Consume() and Messages() after reconnect.
#1643
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wallyqs
approved these changes
Jun 10, 2024
piotrpio
force-pushed
the
fix-consumer-reconnect
branch
2 times, most recently
from
496c95f
to
9c4331e
Compare
Jarema
reviewed
Jun 10, 2024
This was referenced Jun 11, 2024
piotrpio
force-pushed
the
fix-consumer-reconnect
branch
2 times, most recently
from
4b04df2
to
c880273
Compare
piotrpio
changed the title
ConsumerInfo() calls in Consume() after reconnect.ConsumerInfo() calls in Consume() and Messages() after reconnect.
piotrpio
force-pushed
the
fix-consumer-reconnect
branch
from
c880273
to
4a13b59
Compare
This fixes an issue in `Consume()` and `Messages()` where a limited number of ConsumerInfo() attempts (10) meant that if JetStream was not available for longer than ~90s after reconnect the process was stopped. The number of retry attempts is now unlimited, reporting a transient error on each failed attempt. Signed-off-by: Piotr Piotrowski <piotr@synadia.com>
piotrpio
force-pushed
the
fix-consumer-reconnect
branch
2 times, most recently
from
6f47d1e
to
35b4ad1
Compare
- `Consume()` and `Messages()` no longer call `ConsumerInfo()` on upon reconnect. - Ordered consumers now reset on each reconnect event. Signed-off-by: Piotr Piotrowski <piotr@synadia.com>
piotrpio
force-pushed
the
fix-consumer-reconnect
branch
from
35b4ad1
to
b6eabcb
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Consume()andMessages()no longer callConsumerInfo()on upon reconnect.Signed-off-by: Piotr Piotrowski piotr@synadia.com