[IMPROVED] Ordered consumer creation and initial config settings #1645
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This changes a few things around creating ordered consumers: - initial ordered consumer creation is now done without retries - fixed an issue where start seq could be invalid when resetting a consumer which did not receive any messages - simplified getConsumerConfig() Signed-off-by: Piotr Piotrowski <piotr@synadia.com>
piotrpio
force-pushed
the
simplify-ordered-config
branch
from
902332f
to
a77ea15
Compare
Jarema
approved these changes
Jun 12, 2024
|
@Jarema While these changes are fine, I did discover a bug when testing with failground. I will create a separate PR for it. |
This was referenced Jun 14, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes a few things around creating ordered consumers:
Signed-off-by: Piotr Piotrowski piotr@synadia.com