Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IMPROVED] Trim trailing slash if set on server address which can cause errors during lookup #1654

Merged
merged 1 commit into from
Jul 17, 2024

[IMPROVED] Trim trailing slash if set on server address which causes …

a8dd85b
Select commit
Loading
Failed to load commit list.
Merged

[IMPROVED] Trim trailing slash if set on server address which can cause errors during lookup #1654

[IMPROVED] Trim trailing slash if set on server address which causes …
a8dd85b
Select commit
Loading
Failed to load commit list.
Travis CI / Travis CI - Pull Request succeeded Jun 19, 2024 in 8m 33s

Build Passed

The build passed, just like the previous build.

Details

This is a pull request build.

It is running a build against the merge commit, after merging #1654 [IMPROVED] Trim trailing slash if set on server address which can cause errors during lookup.
Any changes that have been made to the main branch before the build ran are also included.

Jobs and Stages

This build has three jobs, running in parallel.

Job Go State Notes
6109.1 1.22.x passed
6109.2 1.21.x passed
6109.3 Go: 1.22.x (nats-server@main) 1.22.x passed This job is allowed to fail.

Build Configuration

Build Option Setting
Language Go
Operating System Linux (Xenial)
Go Versions 1.22.x, 1.21.x
Build Configuration
{
  "language": "go",
  "go": [
    "1.22.x",
    "1.21.x"
  ],
  "go_import_path": "github.com/nats-io/nats.go",
  "install": [
    "go get -t ./...",
    "curl -sSfL https://raw.githubusercontent.com/golangci/golangci-lint/master/install.sh | sh -s -- -b $(go env GOPATH)/bin",
    "if [[ \"$TRAVIS_GO_VERSION\" =~ 1.22 ]]; then go install github.com/mattn/goveralls@latest; go install github.com/wadey/gocovmerge@latest; go install honnef.co/go/tools/cmd/staticcheck@latest; go install github.com/client9/misspell/cmd/misspell@latest; fi"
  ],
  "before_script": [
    "$(exit $(go fmt ./... | wc -l))",
    "go vet -modfile=go_test.mod ./...",
    "if [[ \"$TRAVIS_GO_VERSION\" =~ 1.22 ]]; then find . -type f -name \"*.go\" | xargs misspell -error -locale US; GOFLAGS=\"-mod=mod -modfile=go_test.mod\" staticcheck ./...; fi",
    "golangci-lint run ./jetstream/..."
  ],
  "script": [
    "go test -modfile=go_test.mod -v -run=TestNoRace -p=1 ./... --failfast -vet=off",
    "if [[ \"$TRAVIS_GO_VERSION\" =~ 1.22 ]]; then ./scripts/cov.sh TRAVIS; else go test -modfile=go_test.mod -race -v -p=1 ./... --failfast -vet=off -tags=internal_testing; fi"
  ],
  "after_success": [
    "if [[ \"$TRAVIS_GO_VERSION\" =~ 1.22 ]]; then $HOME/gopath/bin/goveralls -coverprofile=acc.out -service travis-ci; fi"
  ],
  "jobs": {
    "include": [
      {
        "name": "Go: 1.22.x (nats-server@main)",
        "go": "1.22.x",
        "before_script": [
          "go get -modfile go_test.mod github.com/nats-io/nats-server/v2@main"
        ]
      }
    ],
    "allow_failures": [
      {
        "name": "Go: 1.22.x (nats-server@main)"
      }
    ]
  },
  "os": "linux",
  "group": "stable",
  "dist": "xenial"
}