jetstream: ordered consumer: handle closed subscriptions gracefully #1666
+3
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Closes #1656 |
zonque
changed the title
zonque
force-pushed
the
daniel/ordered-consumer-closed
branch
from
32fb4da
to
f28e14a
Compare
In `orderedConsumer.reset()`, `retryWithBackoff()` is returned from with `false, nil` in case the subscription is closed. In this case, `var cons Consumer` is still `nil`, and the code crashes in the attempt to cast it to a `pullConsumer` later on. Fix this by catching the `nil` case explicitly. Signed-off-by: Daniel Mack <daniel.mack@holoplot.com>
zonque
force-pushed
the
daniel/ordered-consumer-closed
branch
from
f28e14a
to
1de5b00
Compare
|
This is a regression from 66b92a9 it appears. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In
orderedConsumer.reset(),retryWithBackoff()is returned from withfalse, nilin case the subscription is closed. In this case,var cons Consumeris stillnil, and the code crashes in the attempt to cast it to apullConsumerlater on.Fix this by catching the
nilcase explicitly.Signed-off-by: Daniel Mack daniel.mack@holoplot.com