Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate encoded connections #1674

Merged
merged 4 commits into from
Jul 23, 2024
Merged

Deprecate encoded connections #1674

merged 4 commits into from
Jul 23, 2024

Commits on Jul 10, 2024

  1. [FIXED] Deadlock when accessing subscriptions map on consumer 

    This fixes an issue where a deadlock could occur when calling `Stop()` or
`Drain()` on `ConsumeContext` or `MessagesContext` and then calling `Consume` or
`Messages` immediately.
Switched to using a type-safe implementation of `sync.Map` for subscriptions map
instead of locking the whole consumer state.
Additionally, changed the type of atomic flags from `uint32` to `atomic.UInt32`
to avoid acciental non-atomic reads/writes.

Signed-off-by: Piotr Piotrowski <piotr@synadia.com>
    @piotrpio
    piotrpio committed Jul 10, 2024
    Configuration menu
    Copy the full SHA
    753229d View commit details
    Browse the repository at this point in the history

Commits on Jul 15, 2024

  1. Deprecate encoded connections 

    Signed-off-by: Piotr Piotrowski <piotr@synadia.com>
    @piotrpio
    piotrpio committed Jul 15, 2024
    Configuration menu
    Copy the full SHA
    1c00d55 View commit details
    Browse the repository at this point in the history

  2. Revert "[FIXED] Deadlock when accessing subscriptions map on consumer" 

    This reverts commit 753229d.
    @piotrpio
    piotrpio committed Jul 15, 2024
    Configuration menu
    Copy the full SHA
    14234ec View commit details
    Browse the repository at this point in the history

  3. Moved test back to context_test.go 

    Signed-off-by: Piotr Piotrowski <piotr@synadia.com>
    @piotrpio
    piotrpio committed Jul 15, 2024
    Configuration menu
    Copy the full SHA
    27af381 View commit details
    Browse the repository at this point in the history