[ADDED] Creating iterators for sync subscriptions #1728
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Piotr Piotrowski <piotr@synadia.com>
Jarema
requested changes
Oct 28, 2024
| return nc.subscribe(subj, _EMPTY_, nil, mch, true, nil) | ||
| var errCh chan error | ||
| if nc.Opts.PermissionErrOnSubscribe { | ||
| errCh = make(chan error, 100) |
There was a problem hiding this comment.
I wonder what is the proper size for this channel.
There was a problem hiding this comment.
Good question, I set it to some value without thinking much about this and kind of forgot to analyze it properly. Since we really only push permission errors on this channel and we do it once per subscription, a buffered channel with size 1 should suffice (so that it's not blocking).
| } | ||
| subject := matches[1] | ||
| for _, sub := range nc.subs { | ||
| if sub.Subject == subject && sub.Queue == q && sub.permissionsErr == nil { |
There was a problem hiding this comment.
sub.Queue would be "" if it's non-queue group subscription, right?
There was a problem hiding this comment.
Exactly, so if there is no match for the regex, q will also be "" and it will fulfill this condition.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds iterator capabilities to core NATS subscription. This API extends only to sync subscriptions.
Additionally, this adds an opt-in
PermissionErrOnSubscribeoption, which (if set) causessub.NextMsg()to return permission error if encountered. Due to backwards compatibility this option is disabled by default, but we could consider enabling it by default in future releases.Signed-off-by: Piotr Piotrowski piotr@synadia.com