Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIXED] twice respMap nil check #1751

Merged
merged 1 commit into from
Dec 17, 2024
Merged

[FIXED] twice respMap nil check #1751

merged 1 commit into from
Dec 17, 2024

Conversation

ramonberrutti
Copy link
Contributor

  • Remove respMap check from createNewRequestAndSend as in already done by: newRespInbox
  • Remove respMap check from clearPendingRequestCalls as the for will already check for us: https://go.dev/play/p/FTzU6FRDSnv

@ramonberrutti ramonberrutti changed the title [FIX] twice respMap nil check [FIXED] twice respMap nil check Dec 16, 2024
@ramonberrutti ramonberrutti force-pushed the fix-respmap-double-nil-check branch from 1f8da2a to f367858 Compare December 16, 2024 17:14
@coveralls
Copy link

coveralls commented Dec 16, 2024 •
edited
Loading

Coverage Status

coverage: 84.874% (+0.02%) from 84.853%
when pulling f367858 on ramonberrutti:fix-respmap-double-nil-check
into 01fafde on nats-io:main.

@ramonberrutti ramonberrutti reopened this Dec 16, 2024
@ramonberrutti ramonberrutti reopened this Dec 16, 2024
piotrpio
piotrpio approved these changes Dec 17, 2024
View reviewed changes
Copy link
Collaborator

@piotrpio piotrpio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the contribution!

@piotrpio piotrpio merged commit 074c819 into nats-io:main Dec 17, 2024
7 of 10 checks passed
@piotrpio piotrpio mentioned this pull request Dec 17, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@piotrpio piotrpio piotrpio approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ramonberrutti @coveralls @piotrpio