Fixed deprecated protobuf import reported by staticcheck #557
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
"encoders/protobuf/protobuf_enc.go:19:2: package github.com/golang/protobuf/proto is deprecated: Use the "google.golang.org/protobuf/proto" package instead." I have replaced and regenerated the testdata protobuf code. I have tested that if an app was built with the library before the change and would receive a message generated with the updated import it would work fine. However an app using the updated library would need to replace ``` reflect.DeepEqual(m1, m2) ``` with ``` reflect.DeepEqual(m1.ProtoReflect(), m2.ProtoReflect()) ``` The protobuf Message has different versions now. Not sure if this going to break things or not, but the github.com/golang/protobuf/proto is clearly marked as deprecated. Signed-off-by: Ivan Kozlovic <ivan@synadia.com>
wallyqs
approved these changes
Apr 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Staticcheck test would fail with this error:
"encoders/protobuf/protobuf_enc.go:19:2: package github.com/golang/protobuf/proto is deprecated: Use the "google.golang.org/protobuf/proto" package instead."
I have replaced and regenerated the testdata protobuf code.
I have tested that if an app was built with the library before
the change and would receive a message generated with the updated
import it would work fine.
However an app using the updated library would need to replace
with
The protobuf Message has different versions now.
Not sure if this going to break things or not, but the
github.com/golang/protobuf/proto is clearly marked as deprecated.
Signed-off-by: Ivan Kozlovic ivan@synadia.com