Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change default flush timeout to 10s #561

Merged
merged 1 commit into from
Apr 27, 2020
Merged

Change default flush timeout to 10s #561

merged 1 commit into from
Apr 27, 2020

Conversation

derekcollison
Copy link
Member

Signed-off-by: Derek Collison derek@nats.io

@derekcollison
Change default flush timeout to 10s
1a5ab25 
Signed-off-by: Derek Collison <derek@nats.io>
@coveralls
Copy link

Coverage Status

Coverage remained the same at 91.669% when pulling 1a5ab25 on flush_timeout into 076024f on master.

wallyqs
wallyqs approved these changes Apr 27, 2020
View reviewed changes
Copy link
Member

@wallyqs wallyqs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@derekcollison derekcollison merged commit 35f1342 into master Apr 27, 2020
@derekcollison derekcollison deleted the flush_timeout branch April 27, 2020 17:41
@ColinSullivan1 ColinSullivan1 mentioned this pull request May 5, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wallyqs wallyqs wallyqs approved these changes

@spacejam spacejam Awaiting requested review from spacejam

@kozlovic kozlovic Awaiting requested review from kozlovic

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@derekcollison @coveralls @wallyqs