[ADDED] RetryOnFailedConnect option #581
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wallyqs
reviewed
Jul 7, 2020
Normally, nats.Connect() would fail if there is no server available when this call is executed. With this new option, if no connection can be made, this call will return no error and will trigger code similar to the reconnect code. Therefore, MaxReconnect and ReconnectWait options are used as if the library had been disconnected and is trying to reconnect. Note that subscription and publish calls will also behave as if the library was in reconnection mode, which means that the calls are buffered and produce no error until the reconnect buffer size is full. Obviously, since the connection is not connected, Flush or Request/Reply calls would timeout. If the ReconnectHandler is set, it will be invoked if the library connects asynchronously. Unrelated: fixed a test that had a t.skip()... Resolves #195 Signed-off-by: Ivan Kozlovic <ivan@synadia.com>
kozlovic
force-pushed
the
retry_on_failed_connect
branch
from
84f9128
to
8a78c4e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Normally, nats.Connect() would fail if there is no server available
when this call is executed. With this new option, if no connection
can be made, this call will return no error and will trigger code
similar to the reconnect code. Therefore, MaxReconnect and ReconnectWait
options are used as if the library had been disconnected and is trying
to reconnect.
Note that subscription and publish calls will also behave as if the
library was in reconnection mode, which means that the calls are
buffered and produce no error until the reconnect buffer size is
full.
Obviously, since the connection is not connected, Flush or Request/Reply
calls would timeout.
If the ReconnectHandler is set, it will be invoked if the library
connects asynchronously.
Unrelated: fixed a test that had a t.skip()...
Resolves #195
Signed-off-by: Ivan Kozlovic ivan@synadia.com