Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated nats.Handler documentation to make it generic to all encoders #590

Merged
merged 1 commit into from
Aug 28, 2020
Merged

Updated nats.Handler documentation to make it generic to all encoders #590

merged 1 commit into from
Aug 28, 2020

Conversation

aym-v
Copy link
Contributor

@aym-v aym-v commented Aug 28, 2020

Small fix that I thought of while encoding my connection using Protocol Buffers 👍

@coveralls
Copy link

Coverage Status

Coverage increased (+0.1%) to 91.527% when pulling 944aa4d on valaymerick:handler-documentation into cd74bc0 on nats-io:master.

kozlovic
kozlovic approved these changes Aug 28, 2020
View reviewed changes
Copy link
Member

@kozlovic kozlovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you for the contribution!

@kozlovic kozlovic merged commit e8f2b4a into nats-io:master Aug 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kozlovic kozlovic kozlovic approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aym-v @coveralls @kozlovic