Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIXED] Possible data race on auto-unsubscribe #726

Merged
merged 1 commit into from
May 3, 2021
Merged

[FIXED] Possible data race on auto-unsubscribe #726

merged 1 commit into from
May 3, 2021

Conversation

kozlovic
Copy link
Member

@kozlovic kozlovic commented May 3, 2021

There was a possible data race between AutoUnsubscribe() and the go routine dispatching messages.

Signed-off-by: Ivan Kozlovic ivan@synadia.com

@kozlovic
[FIXED] Possible data race on auto-unsubscribe
049c0b5 
Signed-off-by: Ivan Kozlovic <ivan@synadia.com>
@kozlovic kozlovic requested a review from variadico May 3, 2021 19:45
@coveralls
Copy link

Coverage Status

Coverage increased (+0.07%) to 86.99% when pulling 049c0b5 on fix_sub_race into aa61ea3 on master.

derekcollison
derekcollison approved these changes May 3, 2021
View reviewed changes
Copy link
Member

@derekcollison derekcollison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kozlovic kozlovic merged commit aa78bbf into master May 3, 2021
@kozlovic kozlovic deleted the fix_sub_race branch May 3, 2021 21:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@derekcollison derekcollison derekcollison approved these changes

@variadico variadico Awaiting requested review from variadico

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kozlovic @coveralls @derekcollison