Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIXED] Possible lock inversion and incorrect delete of JS consumer #792

Closed
wants to merge 2 commits into from
Closed

[FIXED] Possible lock inversion and incorrect delete of JS consumer #792

wants to merge 2 commits into from

Commits on Aug 10, 2021

  1. [FIXED] Possible lock inversion and incorrect delete of JS consumer 

    - Some refactoring to prevent lock inversion (no connection publish
should be done under the subscription lock).
- Remove used of jsSub mutex since so far everything can be done
under the protection of the subscription's lock.
- Attempt to delete JS consumer on Unsubscribe *only* if the library
called AddConsumer and got a success.

Resolves #775
Resolves #776

Signed-off-by: Ivan Kozlovic <ivan@synadia.com>
    @kozlovic
    kozlovic committed Aug 10, 2021
    Configuration menu
    Copy the full SHA
    00b033f View commit details
    Browse the repository at this point in the history

Commits on Aug 11, 2021

  1. Added DeleteConsumer() subscription option 

    If set, the JS consumer will be deleted:
- On Unsubscribe(), if error occurs, error is returned.
- After Drain (connection and/or subscription) completes. If error
occurs there, error is reported through async error cb.

Signed-off-by: Ivan Kozlovic <ivan@synadia.com>
    @kozlovic
    kozlovic committed Aug 11, 2021
    Configuration menu
    Copy the full SHA
    edbc1cd View commit details
    Browse the repository at this point in the history