Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More meaningful message when trying to ack message that was already acknowledged #862

Merged

Conversation

Berreek
Copy link
Contributor

@Berreek Berreek commented Nov 14, 2021

Relates to: #857

Introducing dedicated err for case when trying to ack msg that was already acknowledged.

…trying to ack msg that was already acknowledged.
@coveralls
Copy link

Coverage Status

Coverage increased (+0.02%) to 84.891% when pulling 67333f2 on Berreek:improve-error-msg-for-acking-already-acked-msgs into 84e8b4d on nats-io:main.

Copy link
Member

@wallyqs wallyqs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Berreek
Copy link
Contributor Author

Berreek commented Nov 17, 2021

@wallyqs If everything is I think you have to merge it since I don't have such possibility.

Copy link
Member

@derekcollison derekcollison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants