-
Notifications
You must be signed in to change notification settings - Fork 154
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
KV Transform support. #1098
KV Transform support. #1098
Conversation
…ver subscriptions.
@@ -71,6 +71,7 @@ protected MessageInfo _getBySeq(long seq) throws IOException, JetStreamApiExcept | |||
|
|||
protected void visitSubject(String subject, DeliverPolicy deliverPolicy, boolean headersOnly, boolean ordered, MessageHandler handler) throws IOException, JetStreamApiException, InterruptedException { | |||
PushSubscribeOptions pso = PushSubscribeOptions.builder() | |||
.stream(streamName) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's always better to supply the stream when you know it, this should have been there originally.
@@ -132,6 +131,7 @@ public SourceBaseBuilder(SourceBase base) { | |||
this.startTime = base.startTime; | |||
this.filterSubject = base.filterSubject; | |||
this.external = base.external; | |||
this.subjectTransforms = base.getSubjectTransforms(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was originally missed.
@@ -1392,7 +1393,7 @@ public void testMiscCoverage() throws Exception { | |||
} | |||
|
|||
@Test | |||
public void testMirrorSoureceBuilderPrefixConversion() throws Exception { | |||
public void testMirrorSourceBuilderPrefixConversion() throws Exception { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed spelling
KV Transform support by ensuring using stream name in KV under the cover subscriptions. Also fixed not properly building StreamConfiguration for transform