KV Transform support. #1098
Merged
KV Transform support. #1098
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ver subscriptions.
scottf
changed the title
scottf
commented
Mar 20, 2024
| @@ -71,6 +71,7 @@ protected MessageInfo _getBySeq(long seq) throws IOException, JetStreamApiExcept | |||
|
|
|||
| protected void visitSubject(String subject, DeliverPolicy deliverPolicy, boolean headersOnly, boolean ordered, MessageHandler handler) throws IOException, JetStreamApiException, InterruptedException { | |||
| PushSubscribeOptions pso = PushSubscribeOptions.builder() | |||
| .stream(streamName) | |||
There was a problem hiding this comment.
It's always better to supply the stream when you know it, this should have been there originally.
scottf
commented
Mar 20, 2024
| @@ -132,6 +131,7 @@ public SourceBaseBuilder(SourceBase base) { | |||
| this.startTime = base.startTime; | |||
| this.filterSubject = base.filterSubject; | |||
| this.external = base.external; | |||
| this.subjectTransforms = base.getSubjectTransforms(); | |||
There was a problem hiding this comment.
This was originally missed.
scottf
commented
Mar 20, 2024
| @@ -1392,7 +1393,7 @@ public void testMiscCoverage() throws Exception { | |||
| } | |||
|
|
|||
| @Test | |||
| public void testMirrorSoureceBuilderPrefixConversion() throws Exception { | |||
| public void testMirrorSourceBuilderPrefixConversion() throws Exception { | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
KV Transform support by ensuring using stream name in KV under the cover subscriptions. Also fixed not properly building StreamConfiguration for transform