Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test for NKey.clear #663

Merged
merged 1 commit into from
Jun 30, 2022
Merged

Add test for NKey.clear #663

merged 1 commit into from
Jun 30, 2022

Conversation

lacinoire
Copy link
Contributor

@lacinoire lacinoire commented Jun 20, 2022

Test that key.getPrivateKey() throws an IllegalArgumentException when clear is called.
This tests the method NKey.clear.
This test is based on the test testEquals.

(I wrote this test as part of a research study at TU Delft. Find out more)

@scottf
Copy link
Contributor

scottf commented Jun 20, 2022

@lacinoire Thank you for your contribution. Can you do 2 things? 1. Please add a blank line at the end of the file. 2. Can you add into the PR some description about the test? Thanks!

@lacinoire
Copy link
Contributor Author

lacinoire commented Jun 30, 2022

Okay @scottf! done both 🙂

@scottf
Copy link
Contributor

scottf commented Jun 30, 2022

coveralls is not reporting, using admin merge.

@scottf scottf merged commit 24029dc into nats-io:main Jun 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants