Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Reconnect Jitter #385

Merged
merged 8 commits into from
Jun 24, 2020
Merged

Add Reconnect Jitter #385

merged 8 commits into from
Jun 24, 2020

Conversation

ColinSullivan1
Copy link
Member

Add some jitter to the reconnect wait.

See:

Signed-off-by: Colin Sullivan colin@synadia.com

Signed-off-by: Colin Sullivan <colin@synadia.com>
Copy link
Member

@kozlovic kozlovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM about the logic, will let others judge on the .NET language specifics.

Signed-off-by: Colin Sullivan <colin@synadia.com>
Copy link
Collaborator

@watfordgnf watfordgnf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some questions and comments.

src/NATS.Client/Conn.cs Outdated Show resolved Hide resolved
src/NATS.Client/Conn.cs Show resolved Hide resolved
src/NATS.Client/NATS.cs Outdated Show resolved Hide resolved
src/NATS.Client/NATS.cs Outdated Show resolved Hide resolved
src/NATS.Client/NATS.cs Outdated Show resolved Hide resolved
src/NATS.Client/NATS.cs Show resolved Hide resolved
src/NATS.Client/Conn.cs Outdated Show resolved Hide resolved
ColinSullivan1 and others added 4 commits June 1, 2020 16:05
Co-authored-by: Christopher Watford <christopher.watford@ge.com>
Co-authored-by: Christopher Watford <christopher.watford@ge.com>
Co-authored-by: Christopher Watford <christopher.watford@ge.com>
Signed-off-by: Colin Sullivan <colin@synadia.com>
@ColinSullivan1
Copy link
Member Author

Works locally, but need to fix some flappers in CI.

Signed-off-by: Colin Sullivan <colin@synadia.com>
@ColinSullivan1 ColinSullivan1 merged commit 61b0c87 into master Jun 24, 2020
@ColinSullivan1 ColinSullivan1 deleted the recon-jitter branch June 25, 2020 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants