Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix telemetry header readonly error #719

Merged
merged 15 commits into from
Jan 27, 2025
Merged

Fix telemetry header readonly error #719

merged 15 commits into from
Jan 27, 2025

Conversation

mtmk
Copy link
Collaborator

@mtmk mtmk commented Jan 17, 2025

@mtmk mtmk mentioned this pull request Jan 17, 2025
Closed
mtmk
mtmk commented Jan 17, 2025
View reviewed changes
src/NATS.Client.Core/NatsConnection.Publish.cs
@@ -11,6 +11,7 @@ public ValueTask PublishAsync(string subject, NatsHeaders? headers = default, st
if (Telemetry.HasListeners())
{
using var activity = Telemetry.StartSendActivity($"{SpanDestinationName(subject)} {Telemetry.Constants.PublishActivityName}", this, subject, replyTo);
Telemetry.AddTraceContextHeaders(activity, ref headers);
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this was a bug fix

@mtmk mtmk added the bug fix label Jan 20, 2025
@mtmk mtmk requested a review from scottf January 20, 2025 14:35
@mtmk mtmk self-assigned this Jan 24, 2025
@mtmk mtmk added the priority label Jan 25, 2025
scottf
scottf approved these changes Jan 27, 2025
View reviewed changes
Copy link
Contributor

@scottf scottf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mtmk mtmk merged commit ead42bb into main Jan 27, 2025
13 checks passed
@mtmk mtmk deleted the fix-publish-telemetry branch January 27, 2025 16:38
mtmk added a commit that referenced this pull request Jan 27, 2025
@mtmk
Release 2.5.7
c138a1f 
* Fix telemetry header readonly error (#719)
* Add NatsClient to DI (#689)
* Add callback to NatsAuthOpts that allows refreshing a Token (#712)
* Implement Lame Duck Mode Event Handler (#716)
* Add CreateOrUpdateStoreAsync (#707)
@mtmk mtmk mentioned this pull request Jan 27, 2025
Merged
mtmk added a commit that referenced this pull request Jan 27, 2025
@mtmk
Release 2.5.7 (#729)
7177140 
* Fix telemetry header readonly error (#719)
* Add NatsClient to DI (#689)
* Add callback to NatsAuthOpts that allows refreshing a Token (#712)
* Implement Lame Duck Mode Event Handler (#716)
* Add CreateOrUpdateStoreAsync (#707)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@scottf scottf scottf approved these changes

Assignees

@mtmk mtmk

Labels
bug fix priority
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update on ReadOnly Headers after Retry
2 participants
@mtmk @scottf