Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change port for some tests #1344

Merged
merged 1 commit into from
Nov 18, 2024
Merged

Change port for some tests #1344

merged 1 commit into from
Nov 18, 2024

Conversation

Jarema
Copy link
Member

@Jarema Jarema commented Nov 18, 2024

As port 7777 is used by some tools, like Prometheus, it is easy to get into conflict.
Additionally, Github Actions Windows machines seem to run something on that port.

Signed-off-by: Tomasz Pietrek tomasz@nats.io

@Jarema Jarema force-pushed the debug-op branch 2 times, most recently from 680e98e to ecb8b90 Compare November 18, 2024 12:35
@Jarema Jarema changed the title Debug windows test failure Change port for some tests Nov 18, 2024
@Jarema Jarema marked this pull request as ready for review November 18, 2024 15:58
Signed-off-by: Tomasz Pietrek <tomasz@nats.io>
Copy link
Member

@aricart aricart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@piotrpio piotrpio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Jarema Jarema merged commit 65c7f3c into main Nov 18, 2024
12 checks passed
@Jarema Jarema deleted the debug-op branch November 18, 2024 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants