Improve TLS connection resilience #881
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tomasz Pietrek <tomasz@nats.io>
async-nats/src/connector.rs
Outdated
| @@ -301,21 +301,8 @@ impl Connector { | |||
| .map_err(|err| ConnectError::with_source(crate::ConnectErrorKind::Tls, err))?; | |||
|
|
|||
| // Use the server-advertised hostname to validate if given as a hostname, not an IP address | |||
There was a problem hiding this comment.
This comment is now wrong
Until now, it was possible to procure MitM attack by acting as malicious fake server. This commit removes that possibility by never trusting pre-tls addresses provided by the NATS server. For now it has to be based of tokio-rustls fork, as ruslts support for IP addresses is not yet released. This points tokio-rustls to rustls main branch. No custom code added. Signed-off-by: Tomasz Pietrek <tomasz@nats.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Until now, it was possible to procure MitM attack by acting
as a malicious fake server.
This commit removes that possibility by never trusting pre-tls
addresses provided by the NATS server.
For now, it has to be based of tokio-rustls fork, as ruslts support
for IP addresses is not yet released.
This points tokio-rustls to rustls main branch. No custom code was added.
Signed-off-by: Tomasz Pietrek tomasz@nats.io