-
Notifications
You must be signed in to change notification settings - Fork 102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: RTT helpers for NGS endpoints #921
Conversation
.. to be able to specify custom servers as a target
Unfortunately no I don’t think we can add a NGS specific command in here. As a generic open source command we can’t really put a bunch of stuff specific to a commercial offering in here. I like the use case here (though I would rather try to find clusters dynamically as there are no guarantees about what NGS cluster are up and how long) We could though deliver it as a plugin. |
Yes, I understand the reason and expected something like that, therefore I didn't go into the details. So I am closing PR. Motivation and my use case are simple (although maybe not so common): I'd like to measure latencies between clients, from different regions and between different regions, and using explicit Region Endpoint for that test is quite good approximation. Currently, I am doing that by specifying |
Related to your comments:
Did you mean to have some primitives within natscli to define cluster and supper-cluster configuration or you have something else in mind?
Wasn't aware of the plugin capability tbh, you meant this I guess: https://github.com/nats-io/natscli/blob/main/plugins/plugins.go |
The plugin ability is a bit new and we are not sure yet how exactly we want to handle plugin installation hence it being hidden atm. The short answer is: write your CLI using https://github.com/choria-io/fisk. You develop like “ngs rtt” in /bin/ngs and then you do “nats plugin register ngs /bin/ngs” and that’s it. Longer answer is we can support any language and framework but need to doc up the integration protocol still. |
As an alternative you could build exactly what you wanted with just a YAML file and https://choria-io.github.io/appbuilder/ appbuilder apps can be plugged into nats cli in the same way |
Thx, I'll take a look |
PR contains the new command that should contain NGS-related helpers.
Currently, RTT sub-command is implemented with following options:
Why another command?
It will be possible to expand
ngs
command with additional helpers, e.g.nats ngs usage
related to queryingnats req ngs.usage XXd
and that will be added in separated PR in case this one is accepted.Examples for
nats ngs rtt