[FIX] nacl should not be undefined when module.exports is defined #21
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context:
Reviewing the ternary clause (above) that determines what to pass as
nacl
to the function: ifmodule.exports
is defined,nacl
will be written intomodule.exports
andglobalThis.nacl
won't be reached in the ternary else clause where it would have been defined. So nacl becomes undefined whenmodule.exports
is defined via the the next statement (show above but copied here for clarity):And the first attempt to work with nacl in the derived websocket projects (nats.ws) results in
.sign
going against the undefined nacl object:This PR makes the nacl assignment mirror the ternary condition, yielding:
See my comment on the related nats.ws issue for additional context.