Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

various fixes regarding enable/disable/validation of Jetstream in the system account #685

Merged
merged 1 commit into from
Dec 23, 2024

Conversation

aricart
Copy link
Member

@aricart aricart commented Dec 23, 2024

  • [FIX] added check for --js-enable=tier on system account

  • [FIX] added bypass to allow --js-disable to work on system account in cases where it was enabled by specifying --js-enable=tier

  • [FIX] enhanced validation to check for system accounts with enabled jetstream

Fixes #684

[FIX] added bypass to allow --js-disable to work on system account in cases where it was enabled by specifying --js-enable=tier
[FIX] enhanced validation to check for system accounts with enabled jetstream
Copy link
Contributor

@scottf scottf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aricart aricart merged commit 296ba90 into main Dec 23, 2024
11 checks passed
@aricart aricart deleted the fix-684 branch December 23, 2024 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

No way to disable Jetstream from system account?
2 participants