Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix helm metrics prefix issue #161

Merged
merged 2 commits into from
Feb 8, 2022

Conversation

andy-g
Copy link
Contributor

@andy-g andy-g commented Feb 7, 2022

When deploying the Prometheus NATS exporter via the standard Helm charts, the metrics prefix is overridden from gnatsd & jetstream to nats.

This has caused issues where using the standard Jetstream dashboard doesn't work on a standard helm deployment. Please see the related conversation here: #155.

On a partially related note, I was also wondering if it's be worth adding a simple docker-compose.yaml file in the walkthrough folder, so anyone interested could easily get a NATS + Prometheus + Prometheus NATS Exporter + Grafana environment up and running. The only concern I have is that we've configured the dashboards as templates to be manually imported (which includes the __inputs & __requires sections), as opposed to exported dashboards to automatically import (which would include the actually values for the prometheus datasource). We could either leave it to the user to still import the dashboard, or include a subfolder with the required configurations for the docker-compose example. Let me now if there's any interest in this and I can spin up a separate PR.

@variadico variadico self-requested a review February 8, 2022 17:52
@variadico variadico merged commit e632b01 into nats-io:main Feb 8, 2022
@variadico
Copy link
Contributor

I was also wondering if it's be worth adding a simple docker-compose.yaml file in the walkthrough

Yeah, that sounds like a good idea.

@andy-g andy-g deleted the fix_helm_metrics_prefix_issue branch February 9, 2022 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants