Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When deploying the Prometheus NATS exporter via the standard Helm charts, the metrics prefix is overridden from
gnatsd
&jetstream
tonats
.This has caused issues where using the standard Jetstream dashboard doesn't work on a standard helm deployment. Please see the related conversation here: #155.
On a partially related note, I was also wondering if it's be worth adding a simple
docker-compose.yaml
file in thewalkthrough
folder, so anyone interested could easily get a NATS + Prometheus + Prometheus NATS Exporter + Grafana environment up and running. The only concern I have is that we've configured the dashboards as templates to be manually imported (which includes the__inputs
&__requires
sections), as opposed to exported dashboards to automatically import (which would include the actually values for the prometheus datasource). We could either leave it to the user to still import the dashboard, or include a subfolder with the required configurations for the docker-compose example. Let me now if there's any interest in this and I can spin up a separate PR.