Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document timestamp precision #328

Closed
palsivertsen opened this issue Sep 17, 2020 · 1 comment · Fixed by nats-io/nats.docs#156 or #329
Closed

Document timestamp precision #328

palsivertsen opened this issue Sep 17, 2020 · 1 comment · Fixed by nats-io/nats.docs#156 or #329

Comments

@palsivertsen
Copy link

The MsgProto type has a field called timestamp, but it's usage is not documented. The precision (s/ms/ns) and base (Unix Epoch?) should be specified.
kozlovic added a commit to nats-io/nats.docs that referenced this issue Sep 18, 2020
@kozlovic
Document MsgProto.Timestamp precision
e12197d 
Resolves nats-io/stan.go#328
@kozlovic kozlovic mentioned this issue Sep 18, 2020
Merged
kozlovic added a commit that referenced this issue Sep 18, 2020
@kozlovic
[DOC] MsgProto.Timestamp precision
5039f2e 
Resolves #328

[ci skip]

Signed-off-by: Ivan Kozlovic <ivan@synadia.com>
@kozlovic kozlovic mentioned this issue Sep 18, 2020
Merged
@kozlovic
Copy link
Member

@palsivertsen Submitted 2 PRs: #329 and nats-io/nats.docs#156. Hope this helps!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@palsivertsen @kozlovic