Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UPDATED] Dependency to NATS v1.11.0 #350

Merged
merged 1 commit into from
May 21, 2021
Merged

[UPDATED] Dependency to NATS v1.11.0 #350

merged 1 commit into from
May 21, 2021

Conversation

kozlovic
Copy link
Member

Also updated the tests dependencies to NATS server v2.2.5 and
NATS Streaming current main branch (that has its dependencies
to NATS Server and other updated).

Signed-off-by: Ivan Kozlovic ivan@synadia.com

Also updated the tests dependencies to NATS server v2.2.5 and
NATS Streaming current main branch (that has its dependencies
to NATS Server and other updated).

Signed-off-by: Ivan Kozlovic <ivan@synadia.com>
@kozlovic kozlovic requested a review from wallyqs May 21, 2021 19:35
@kozlovic
Copy link
Member Author

@wallyqs I would like your opinion. I have updating NATS Streaming servers dependencies but have not yet released. I am now updating stan.go library that uses a test mod file and reference the streaming server's main branch. I was going to release the client, say stan.go:v0.9.0, and then update the streaming server's go.mod to stan.go:v0.9.0 and then release as v0.22.0. The question is: would you do it this way, or first release streaming server v0.22.0 with dep on stan.go:v0.8.3, and then update stan.go with streaming v0.22.0 deps? Both would work, just would like to have someone else take on that?

Copy link
Member

@wallyqs wallyqs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wallyqs
Copy link
Member

wallyqs commented May 21, 2021

Either seems fine but since for the stan.go the server it is only a test dependency I think sounds better to release first the client and then tag the nats-streaming-server with stan.go:v0.9.0

@coveralls
Copy link

Coverage Status

Coverage increased (+0.05%) to 93.05% when pulling 4fdca7d on update_deps into 910e9bc on master.

@kozlovic
Copy link
Member Author

@wallyqs Thanks. But to be clear, the streaming server has nats.go as a dependency for the server code itself, but does not have stan.go as a dependency, just as a test dependency. It just happens that I do not have separate go.mod and go_tests.mod for the server.

@wallyqs
Copy link
Member

wallyqs commented May 21, 2021

@kozlovic yes understand that part, I've found that splitting test deps from go.mod into go_test.mod can be tricky to get right in projects that use vendor because of how go mod vendor works, so single go.mod for now might be easier to work with for the servers

@kozlovic kozlovic merged commit 1de86de into master May 21, 2021
@kozlovic kozlovic deleted the update_deps branch May 21, 2021 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants