Native linux support #178

EchoEllet · 2023-12-03T14:23:14Z

No description provided.

natsuk4ze · 2023-12-03T15:13:25Z

I wanted to take a moment to express my gratitude for your contribution to the project. Your efforts in adding native Linux support are deeply appreciated.

I've noticed that you've been putting in a lot of hard work. Remember, there's no need to overdo it. Adding support for a new platform is inherently challenging and time-consuming.

Most importantly, as this is an open-source project, the best approach is to contribute whenever you feel passionate and inspired to do so. Your well-being and enthusiasm for the project are what truly matter.

Thanks again for your valuable contribution!

Best regards,

EchoEllet · 2023-12-04T04:45:51Z

Let's save the compliments when we are done with Linux support in peace :)

Is there a way where I can contact with you in private? maybe discord or slack channel? anything

natsuk4ze · 2023-12-04T05:08:33Z

discord

@natsuk4ze. you can find me in pub channel on flutter

EchoEllet · 2023-12-04T05:17:30Z

I added the plugin interface for gal without new package or doing a breaking change

natsuk4ze · 2023-12-04T05:43:44Z

I added the plugin interface for gal without new package or doing a breaking change

OK.
I haven't done a thorough investigation of dart-only-platform-implementations yet, but wouldn't this allow us to remove the gal_linux folder and put all your Linux implementations in a linux folder?

EchoEllet · 2023-12-04T05:47:00Z

I added the plugin interface for gal without new package or doing a breaking change

OK.
I haven't done a thorough investigation of dart-only-platform-implementations yet, but wouldn't this allow us to remove the gal_linux folder and put all your Linux implementations in a linux folder?

gal_linux is just a dart implementation package for Linux

We can rename it to linux, but it's really not a big deal

I named it like this to follow conversations of official flutter plugins

Besides, the package will be used only in the Linux platform unlike the previous PR

It's much easier and faster as we don't have to build the whole app again every time we make a change

natsuk4ze · 2023-12-04T05:58:31Z

Two folders for linux is weird, so let's make it one.

EchoEllet · 2023-12-04T06:00:00Z

Two folders for linux is weird, so let's make it one.

Actually, it's one

But if you mean two folders

The other one for the example and this can't be deleted. Otherwise, we can't run the example on Linux

It is just for the example

It won't affect the end developer who will use the library for linux

EchoEllet · 2023-12-04T06:00:48Z

All plugins have two folders for all platforms

One for the example
The other for the plugin itself

natsuk4ze · 2023-12-04T06:04:14Z

Then the linux_gal folder should be under linux.

EchoEllet · 2023-12-04T06:05:53Z

Then the linux_gal folder should be under linux.

We only have a Linux folder under the example

We can't put the platform specific code in the example

Even if we did, the end developer won't get the changes in his own project

natsuk4ze · 2023-12-04T06:11:51Z

We only have a Linux folder under the example

When you add a platform, doesn't it generate a linux folder in the root?

EchoEllet · 2023-12-04T06:17:49Z

We only have a Linux folder under the example

When you add a platform, doesn't it generate a linux folder in the root?

We did that previously, but now, since you wanted dart implementation and actual, I want that too

I depleted the linux native code and created a new package and made some changes in the lib so we have an interface for the plugin without breaking changes

In the gal_linux package, we override the impl of the interface

And we used the package in the main gal package for linux only

Simple as that

The docs are not very clear about dart platform specific code, so I had to take a look at the path provider plugin from the flutter team

natsuk4ze · 2023-12-04T06:36:49Z

There are several ways to add a linux platform, and there are many to choose from.
The choice should be made carefully and after thorough discussion, because we will be using it permanently.

My preference is as stated in the issue,

do not add new dependencies to pubspec.yaml.
putting the all linux-related code in linux folder at the top level, like darwin and android.

We do not have to write the code right away. We should discuss the best way these can be accomplished.

Basically, We need to write native code like others, but if we can achieve this with Dart, Dart is easier.

Anyway, there is no need to rush and don't feel you have to do it alone. To begin with, the demand for linux apps is low compared to other platforms.

natsuk4ze · 2023-12-04T07:00:02Z

One idea is to publish the linux support as your extension package and introduce it in the gal readme. This way you are free to write your code.

EchoEllet · 2023-12-04T07:14:04Z

We only have a Linux folder under the example

When you add a platform, doesn't it generate a linux folder in the root?

We did that previously, but now, since you wanted dart implementation and actual, I want that too

I depleted the linux native code and created a new package and made some changes in the lib so we have an interface for the plugin without breaking changes

In the gal_linux package, we override the impl of the interface

And we used the package in the main gal package for linux only

Simple as that

The docs are not very clear about dart platform specific code, so I had to take a look at the path provider plugin from the flutter team

Don't worry. Even after this PR gets merged, I will still provide extra patches for a while

I added new dependency in pubspec.yaml of gal_linux only

natsuk4ze · 2023-12-04T08:37:36Z

natsuk4ze. is my username

natsuk4ze · 2023-12-04T08:53:20Z

natsuk4ze. is my username

Sent you a message there

Was that the same profile icon? I don't seem to have received it.

natsuk4ze · 2023-12-04T09:07:33Z

I’m not receiving that. my username is “natsuk4ze.”

EchoEllet · 2023-12-04T09:08:00Z

example/.gitignore

@@ -0,0 +1,43 @@
+# Miscellaneous


This whole file is generated by flutter create . --platforms=linux

EchoEllet · 2023-12-04T09:15:03Z

example/README.md

+# example
+
+A new Flutter project.
+
+## Getting Started
+
+This project is a starting point for a Flutter application.
+
+A few resources to get you started if this is your first Flutter project:
+


This will be updated soon

EchoEllet · 2023-12-04T09:16:08Z

example/lib/main.dart

@@ -68,7 +68,7 @@ class _AppState extends State<App> {
                      'https://github.com/natsuk4ze/gal/raw/main/example/assets/done.jpg',
                      path,
                    );
-                    await Gal.putImage(path);
+                    await Gal.putImage(path, album: album);


Bug fix in the example

EchoEllet · 2023-12-04T09:17:36Z

example/lib/main.dart

@@ -80,7 +80,7 @@ class _AppState extends State<App> {
                      'https://github.com/natsuk4ze/gal/raw/main/example/assets/done.mp4',
                      path,
                    );
-                    await Gal.putVideo(path);
+                    await Gal.putVideo(path, album: album);


EchoEllet · 2023-12-04T09:20:06Z

example/windows/flutter/ephemeral/.plugin_symlinks/gal

@@ -0,0 +1 @@
+/home/freshtechtips/Desktop/gal/


This should be deleted

EchoEllet · 2023-12-04T09:23:26Z

pubspec.yaml

@@ -25,6 +33,7 @@ environment:
 dependencies:
  flutter:
    sdk: flutter
+  plugin_platform_interface: ^2.1.7


This is used in all offical flutter plugins

EchoEllet · 2023-12-04T09:23:56Z

pubspec.yaml

+platforms:
+  android:
+  ios:
+  linux:
+  macos:
+  windows:


Just to avoid pubspec.yaml from showing Linux as unsupported

Ellet added 3 commits December 3, 2023 16:43

Add Linux platform project in the example

fd3bc01

Add Linux platform spesefic code plugin

258a707

Update pubspec.yaml

2385057

EchoEllet closed this Dec 3, 2023

EchoEllet reopened this Dec 4, 2023

Plugin platform interface

7b1584b

Impl from previous PR

98ab54e

Update pubspec.yaml

62e2d57

Ellet added 2 commits December 4, 2023 09:08

A few changes

d0cfb39

Remove example video

ea8186b

Ellet added 3 commits December 4, 2023 11:05

Bug fixes

0c13254

Bug fixes 2

327a102

Bug fixes 3

82c6166

EchoEllet marked this pull request as ready for review December 4, 2023 09:06

EchoEllet requested a review from natsuk4ze as a code owner December 4, 2023 09:06

EchoEllet commented Dec 4, 2023

View reviewed changes

example/.gitignore

@@ -0,0 +1,43 @@

# Miscellaneous

Copy link

Contributor Author

EchoEllet Dec 4, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This whole file is generated by flutter create . --platforms=linux

EchoEllet commented Dec 4, 2023

View reviewed changes

Ellet added 4 commits December 4, 2023 12:34

docs: Update READEME.md

1ade0e0

revert: Linux impl

22542da

revert: Add linux as supported platform

33b125d

revert: Bug fix

c5b7281

natsuk4ze mentioned this pull request Dec 4, 2023

Add Plugin platform interface #180

Merged

EchoEllet closed this Dec 4, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Native linux support #178

Native linux support #178

EchoEllet commented Dec 3, 2023 •

edited

Loading

natsuk4ze commented Dec 3, 2023

EchoEllet commented Dec 4, 2023

natsuk4ze commented Dec 4, 2023

EchoEllet commented Dec 4, 2023

natsuk4ze commented Dec 4, 2023

EchoEllet commented Dec 4, 2023

natsuk4ze commented Dec 4, 2023

EchoEllet commented Dec 4, 2023

EchoEllet commented Dec 4, 2023

natsuk4ze commented Dec 4, 2023

EchoEllet commented Dec 4, 2023 •

edited

Loading

natsuk4ze commented Dec 4, 2023

EchoEllet commented Dec 4, 2023

natsuk4ze commented Dec 4, 2023 •

edited

Loading

natsuk4ze commented Dec 4, 2023

EchoEllet commented Dec 4, 2023

natsuk4ze commented Dec 4, 2023

natsuk4ze commented Dec 4, 2023

natsuk4ze commented Dec 4, 2023

EchoEllet Dec 4, 2023

EchoEllet Dec 4, 2023

EchoEllet Dec 4, 2023

EchoEllet Dec 4, 2023

EchoEllet Dec 4, 2023

EchoEllet Dec 4, 2023

EchoEllet Dec 4, 2023

		@@ -0,0 +1 @@
		/home/freshtechtips/Desktop/gal/

Native linux support #178

Native linux support #178

Conversation

EchoEllet commented Dec 3, 2023 • edited Loading

natsuk4ze commented Dec 3, 2023

EchoEllet commented Dec 4, 2023

natsuk4ze commented Dec 4, 2023

EchoEllet commented Dec 4, 2023

natsuk4ze commented Dec 4, 2023

EchoEllet commented Dec 4, 2023

natsuk4ze commented Dec 4, 2023

EchoEllet commented Dec 4, 2023

EchoEllet commented Dec 4, 2023

natsuk4ze commented Dec 4, 2023

EchoEllet commented Dec 4, 2023 • edited Loading

natsuk4ze commented Dec 4, 2023

EchoEllet commented Dec 4, 2023

natsuk4ze commented Dec 4, 2023 • edited Loading

natsuk4ze commented Dec 4, 2023

EchoEllet commented Dec 4, 2023

natsuk4ze commented Dec 4, 2023

natsuk4ze commented Dec 4, 2023

natsuk4ze commented Dec 4, 2023

EchoEllet Dec 4, 2023

Choose a reason for hiding this comment

EchoEllet Dec 4, 2023

Choose a reason for hiding this comment

EchoEllet Dec 4, 2023

Choose a reason for hiding this comment

EchoEllet Dec 4, 2023

Choose a reason for hiding this comment

EchoEllet Dec 4, 2023

Choose a reason for hiding this comment

EchoEllet Dec 4, 2023

Choose a reason for hiding this comment

EchoEllet Dec 4, 2023

Choose a reason for hiding this comment

EchoEllet commented Dec 3, 2023 •

edited

Loading

EchoEllet commented Dec 4, 2023 •

edited

Loading

natsuk4ze commented Dec 4, 2023 •

edited

Loading