Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Angular 9 compatibility #34

Closed
raymondboswel opened this issue Feb 24, 2020 · 8 comments
Closed

Angular 9 compatibility #34

raymondboswel opened this issue Feb 24, 2020 · 8 comments

Comments

@raymondboswel
Copy link

After upgrading to angular 9 I get the following:

image

I have forked the project and will try figure out what the fix is, but any assistance would be great.

@nosTa1337
Copy link

Same here.

[ng] ERROR in The given rootPath undefined is not a file of the program..../node_modules/ngrx-store-ionic-storage/dist/index.d.ts

@raymondboswel
Copy link
Author

It's not a real solution, but the lib is pretty light weight, so I just copied the contents into my project. I ran into a bunch of other issues migrating to v9, so giving up for now.

@nosTa1337
Copy link

@raymondboswel I was also thinking about investigating but I will wait as well as I do not have the need to upgrade to v9. All the luck to those who are going with V9 already.

@BDominik
Copy link

Hi I'm also using the ngrx 9 and angular 9.
I really liked this package and worked fine with ionic 4 and older angular.
So for those who want elegant solution for this they can read this article.
https://medium.com/better-programming/sync-your-state-in-local-storage-with-ngrx-9d6ceba93fc0
I had to modify it to filter specific actions though.
Good luck with it.

@costafrancesco94
Copy link

I managed to made it work putting "angularCompilerOptions": { "enableIvy": false } as last line in the configuration object of my tsconfig.app.json. Don't really know what Ivi is, but it worked.
Solution suggested from this issue

package.json

"@angular/common": "~9.1.6",
    "@angular/core": "~9.1.6",
    "@angular/forms": "~9.1.6",
    "@angular/platform-browser": "~9.1.6",
    "@angular/platform-browser-dynamic": "~9.1.6",
    "@angular/router": "~9.1.6",
    "@capacitor/android": "^2.1.2",
    "@capacitor/core": "^2.4.0",
    "@ionic/angular": "^5.0.0",
    "@ionic/storage": "^2.3.0",
    "@ngrx/core": "^1.2.0",
    "@ngrx/effects": "^9.2.0",
    "@ngrx/store": "^9.2.0",
    "ngrx-store-ionic-storage": "^5.0.0",

@JustDoItSascha
Copy link

Error: The given rootPath undefined is not a file of the program.

Is there any update on this? It still not works with Angular >9 and Ionic 5.

@raymondboswel
Copy link
Author

@JustDoItSascha My previous comment offers a really simple solution: #34 (comment)

@JustDoItSascha
Copy link

@raymondboswel Thank you, yeah I didn't see this and you're right, this was very easy! Now it runs with ionic 5 and angular 10 :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants