Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1.8 (not for merge) #481

Open
wants to merge 95 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
95 commits
Select commit Hold shift + click to select a range
761049d
skip exact md5 ndigest tests on CRAN
jefferis Aug 9, 2019
f97dc99
dev: ignore spare directory
jefferis Jul 18, 2019
f622b6b
upgrade roxygen
jefferis Aug 21, 2019
659f855
Fix if logical length >1 error
jefferis Aug 21, 2019
ec1f9bf
Fix CMTK/Vaa3D URLs
jefferis Aug 21, 2019
9d54291
Update URLs for natverse GitHub organisation
jefferis Aug 22, 2019
57006d4
Fix slow reading of neuronlistfh
jefferis Jul 18, 2019
8d91724
Bump version to 1.8.13
jefferis Aug 21, 2019
8993069
Update NEWS for 1.8.13
jefferis Aug 9, 2019
197b74f
update cran comments for 1.8.13 release
jefferis Aug 22, 2019
096b638
Add ORCIDs to authors
jefferis Aug 22, 2019
7742343
whitespace
jefferis Aug 24, 2019
235278a
Upgrade roxygen
jefferis Feb 6, 2020
2fde535
donttest example depending on suggested package
jefferis Feb 6, 2020
9eaf796
update baseline of ndigest test
jefferis Feb 6, 2020
e40e0bd
travis: switch to xenial
jefferis Feb 6, 2020
c51cdcf
Bump version and news
jefferis Feb 7, 2020
174fafb
update cran comments (as released)
jefferis Feb 7, 2020
5a6471d
Fix test for new behaviour of c() in R 4.1
jefferis Sep 9, 2020
5f51156
URL updates
jefferis Sep 14, 2020
fa2ac55
Fix more URLs for CRAN
jefferis Sep 22, 2020
9a6eef4
Update news and bump version
jefferis Sep 22, 2020
baf85b3
update cran comments
jefferis Sep 22, 2020
93dce68
git ignore CRAN-RELEASE file
jefferis Sep 22, 2020
594a7e9
more URL fixes from CRAN pre-test
jefferis Sep 22, 2020
7e81da6
Bump version for URL fixes
jefferis Sep 22, 2020
ed35505
Update cran comments
jefferis Sep 25, 2020
508960f
suggest webshot2
jefferis Aug 24, 2021
cfe4916
roxygenise
jefferis Aug 24, 2021
211ae1f
fix roxygen error
jefferis Aug 24, 2021
0258aac
docs: spelling
jefferis Aug 24, 2021
d2ecca2
add github actions rcmd check
jefferis Aug 25, 2021
9d959cd
remove outdated travis
jefferis Aug 25, 2021
6ac97a4
update to README from master + nature img fix
jefferis Aug 25, 2021
65ff352
URL (inc DOI) fixes
jefferis Aug 25, 2021
ece97fe
Bump version, news
jefferis Aug 25, 2021
b275deb
ignore .github folder when building package
jefferis Aug 25, 2021
d2679ac
redown
jefferis Sep 3, 2021
e0918cf
Update cran comments
jefferis Sep 3, 2021
4df952c
cran comments tweaks
jefferis Sep 3, 2021
b540ce8
Suggest markdown package as fallback for pandoc
jefferis Sep 3, 2021
923bbad
cran comment tweaks
jefferis Sep 3, 2021
6c1057b
conditional renderind of rgl stuff in vignette
jefferis Sep 3, 2021
63c9a90
redown
jefferis Sep 3, 2021
b653ec5
last change to cran-comments
jefferis Sep 3, 2021
05e12c9
fix conditional running of pandoc vignettes
jefferis Sep 5, 2021
13b2f40
bump version to 1.8.18
jefferis Sep 5, 2021
fa58525
redown
jefferis Sep 5, 2021
83dff83
finalise 1.8.18 cran comments
jefferis Sep 6, 2021
36b598b
seglist updated to the latest igraph version
dokato Apr 4, 2022
8bd37f7
seglist updated to the latest igraph version - NAMESPACE
dokato Apr 4, 2022
3d51bdc
ctb added
dokato Apr 5, 2022
8066d15
fixes to make CRAN happy
dokato Apr 5, 2022
c0a8528
Merge pull request #495 from dokato/1.8
jefferis Apr 20, 2022
9ec1f8c
dev: update roxygen
jefferis Jan 19, 2023
2fac553
neimode->mode for igraph v1.3
jefferis Jan 19, 2023
666c5cd
replace deprecated rgl.* calls
jefferis Jan 20, 2023
23680b3
rgl.pop -> pop3d
jefferis Jan 13, 2023
8562886
fix outdated teem urls
jefferis Jan 20, 2023
a808a81
remove drat - webshot2 now on CRAN
jefferis Jan 20, 2023
8c25483
fix neuroml urls
jefferis Jan 20, 2023
635d821
fix height of nature image in readme
jefferis Jan 20, 2023
e98adec
add missing readme figures
jefferis Jan 20, 2023
d5466f6
ignore codecov config
jefferis Jan 23, 2023
012ad43
Fix test of attribute length mismatch for new ngraph
jefferis Jan 28, 2023
d9b5ebe
remove one last rgl.* function
jefferis Jan 28, 2023
bb8ab42
Bump version
jefferis Jan 28, 2023
5b84e23
Update cran comments pre-submission
jefferis Jan 28, 2023
f9604b6
ignore CRAN submission file
jefferis Jan 28, 2023
94d1d1d
Fixing NEWS parse error on linux
jefferis Jan 28, 2023
22a4d24
bump version to 1.8.21
jefferis Jan 28, 2023
5810b5e
update CRAN comments for v1.8.21
jefferis Jan 28, 2023
89bce37
Bump version
jefferis Jun 5, 2023
e7e512c
update citation to include natverse paper
jefferis Jun 7, 2023
4af3318
remove broken flycircuit link
jefferis Jun 7, 2023
2f441b0
fix method / generic mismatch
jefferis Jun 7, 2023
ed8a9c5
export methods that check was complaining about
jefferis Jun 7, 2023
2c0ffb1
update CRAN comments for submission
jefferis Jun 7, 2023
c115c49
Increment version number to 1.8.22.9000
jefferis Aug 24, 2023
e3ec0fd
fix bug in handling of numeric versions
jefferis Aug 24, 2023
a1ead0f
Bump version
jefferis Aug 24, 2023
e8ab101
Fix Simple Neurite Tracer / SNT urls
jefferis Aug 25, 2023
886f9cd
update cran comments
jefferis Aug 25, 2023
7edb6f0
rename all deprecated igraph functions
jefferis Jan 31, 2024
86ad05e
igraph tweaks & typos
jefferis Jan 20, 2024
c6f6808
igraph dfs may signal unreachable nodes with 0
jefferis Jan 20, 2024
8bbc822
suppress startup messages in test
jefferis Jan 31, 2024
786149f
fix new igraph imports
jefferis Jan 31, 2024
4e3d657
nvertices.igraph fixes vcount mode
jefferis Jan 31, 2024
679c0ad
Bump version to 1.8.24
jefferis Jan 31, 2024
84e074a
WIP update cran comments
jefferis Jan 31, 2024
a6a1a0c
doc fixes inc \itemize lists
jefferis Jan 31, 2024
f11f10a
skip cmtk command line tests on cran
jefferis Jan 31, 2024
6942ae3
more doc fixes
jefferis Jan 31, 2024
ed86e4d
update cran comments for submission
jefferis Feb 5, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
  •  
  •  
  •  
6 changes: 6 additions & 0 deletions .Rbuildignore
Original file line number Diff line number Diff line change
Expand Up @@ -9,3 +9,9 @@ travisbuildchildren.sh
^build-cmtk.sh$
^build_docs.r$
^vignettes/.*pdf$
^\.httr-oauth$
^spare$
^CRAN-RELEASE$
^.github$
^codecov\.yml$
^CRAN-SUBMISSION$
91 changes: 91 additions & 0 deletions .github/workflows/R-CMD-check.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,91 @@
#on: push
on:
push:
branches:
- main
- master
pull_request:
branches:
- main
- master

name: R-CMD-check

jobs:
R-CMD-check:
runs-on: ${{ matrix.config.os }}

name: ${{ matrix.config.os }} (${{ matrix.config.r }})

strategy:
fail-fast: false
matrix:
config:
#- {os: windows-latest, r: 'release', rglusenull: "true"}
- {os: macOS-latest, r: 'release', rglusenull: "true"}
- {os: ubuntu-20.04, r: 'release', rspm: "https://packagemanager.rstudio.com/cran/__linux__/focal/latest", rglusenull: "true", codecov: "true"}
#- {os: ubuntu-20.04, r: 'devel', rspm: "https://packagemanager.rstudio.com/cran/__linux__/focal/latest"}

env:
R_REMOTES_NO_ERRORS_FROM_WARNINGS: true
RSPM: ${{ matrix.config.rspm }}
GITHUB_PAT: ${{ secrets.GITHUB_TOKEN }}
RGL_USE_NULL: ${{ matrix.config.rglusenull }}

steps:
- uses: actions/checkout@v2

- uses: r-lib/actions/setup-r@master
with:
r-version: ${{ matrix.config.r }}

- uses: r-lib/actions/setup-pandoc@master

- name: Query dependencies
run: Rscript -e "install.packages('remotes')" -e "saveRDS(remotes::dev_package_deps(dependencies = TRUE), 'depends.Rds', version = 2)"

- name: Cache R packages
if: runner.os != 'Windows'
uses: actions/cache@v1
with:
path: ${{ env.R_LIBS_USER }}
key: ${{ runner.os }}-r-${{ matrix.config.r }}-${{ hashFiles('depends.Rds') }}
restore-keys: ${{ runner.os }}-r-${{ matrix.config.r }}-

- name: Install system dependencies
if: runner.os == 'Linux'
env:
RHUB_PLATFORM: linux-x86_64-ubuntu-gcc
run: |
Rscript -e "remotes::install_github('r-hub/sysreqs')"
sysreqs=$(Rscript -e "cat(sysreqs::sysreq_commands('DESCRIPTION'))")
sudo -s eval "$sysreqs"

- name: Install Covr
run: Rscript -e "remotes::install_github('r-lib/covr')"

- name: Build CMTK
run: sh ./build-cmtk.sh
env:
MAKEFLAGS: "-j2"

- name: Install dependencies
run: Rscript -e "library(remotes)" -e "update(readRDS('depends.Rds'))" -e "remotes::install_cran('rcmdcheck')"

- name: Install manual dependencies
run: Rscript -e "remotes::install_github('natverse/natcpp')"

- name: Check
run: Rscript -e "rcmdcheck::rcmdcheck(args = c('--no-manual', '--as-cran'), error_on = 'error', check_dir = 'check')"

- name: Upload check results
if: failure()
uses: actions/upload-artifact@master
with:
name: ${{ runner.os }}-r${{ matrix.config.r }}-results
path: check

- name: Test coverage
if: matrix.config.codecov
run: |
Rscript -e 'covr::codecov(token = "${{secrets.CODECOV_TOKEN}}")'
3 changes: 3 additions & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -4,3 +4,6 @@
inst/doc
*.Rout
docs/figs/*.pdf
tests/testthat/Rplots.pdf
.httr-oauth
spare
30 changes: 0 additions & 30 deletions .travis.yml

This file was deleted.

23 changes: 14 additions & 9 deletions DESCRIPTION
Original file line number Diff line number Diff line change
@@ -1,13 +1,15 @@
Package: nat
Type: Package
Title: NeuroAnatomy Toolbox for Analysis of 3D Image Data
Version: 1.8.12
Version: 1.8.24
Authors@R: c(
person("Gregory", "Jefferis", , "jefferis@gmail.com", role = c("aut", "cre")),
person("James", "Manton", role = c("aut"))
person("Gregory","Jefferis", email="jefferis@gmail.com",
role = c("aut", "cre"), comment = c(ORCID = "0000-0002-0587-9355")),
person("James", "Manton", role = c("aut"), comment = c(ORCID = "0000-0001-9260-3156")),
person("Dominik", "Krzeminski", role = c("ctb"), comment = c(ORCID = "0000-0003-4568-0583"))
)
URL: https://github.com/jefferis/nat, http://jefferislab.org
BugReports: https://github.com/jefferis/nat/issues
URL: https://github.com/natverse/nat, https://natverse.org/
BugReports: https://github.com/natverse/nat/issues
Description: NeuroAnatomy Toolbox (nat) enables analysis and visualisation of 3D
biological image data, especially traced neurons. Reads and writes 3D images
in NRRD and 'Amira' AmiraMesh formats and reads surfaces in 'Amira' hxsurf
Expand All @@ -24,9 +26,9 @@ Depends:
rgl (>= 0.98.1)
Imports:
nabor,
igraph (>= 0.7.1),
igraph (>= 1.3.0),
methods,
filehash,
filehash (>= 2.3),
digest,
nat.utils (>= 0.4.2),
plyr,
Expand All @@ -38,8 +40,10 @@ Suggests:
XML,
knitr,
rmarkdown,
markdown,
MASS,
alphashape3d
alphashape3d,
webshot2
License: GPL-3
LazyData: yes
Collate:
Expand Down Expand Up @@ -84,5 +88,6 @@ Collate:
'xformimage.R'
'xformpoints.R'
'zzz.R'
RoxygenNote: 6.0.1
RoxygenNote: 7.2.3
Encoding: UTF-8
VignetteBuilder: knitr
28 changes: 16 additions & 12 deletions NAMESPACE
Original file line number Diff line number Diff line change
Expand Up @@ -42,13 +42,15 @@ S3method(as.mesh3d,hxsurf)
S3method(as.neuron,data.frame)
S3method(as.neuron,default)
S3method(as.neuron,igraph)
S3method(as.neuron,morphml_cell)
S3method(as.neuron,neuron)
S3method(as.neuron,ngraph)
S3method(as.neuronlist,default)
S3method(as.neuronlist,neuronlistfh)
S3method(as.neuronlistfh,neuronlist)
S3method(as.ngraph,data.frame)
S3method(as.ngraph,igraph)
S3method(as.ngraph,morphml_cell)
S3method(as.ngraph,neuron)
S3method(as.ngraph,ngraph)
S3method(as.seglist,default)
Expand All @@ -67,6 +69,7 @@ S3method(branchpoints,igraph)
S3method(branchpoints,neuron)
S3method(c,neuronlist)
S3method(c,reglist)
S3method(cmtk.targetvolume,character)
S3method(cmtk.targetvolume,default)
S3method(cmtk.targetvolume,im3d)
S3method(cmtk.targetvolume,list)
Expand Down Expand Up @@ -107,6 +110,7 @@ S3method(ndigest,neuron)
S3method(ndigest,neuronlistfh)
S3method(nvertices,default)
S3method(nvertices,dotprops)
S3method(nvertices,igraph)
S3method(nvertices,neuron)
S3method(nvertices,neuronlist)
S3method(plot,neuron)
Expand Down Expand Up @@ -320,24 +324,24 @@ importFrom(digest,digest)
importFrom(igraph,"V<-")
importFrom(igraph,E)
importFrom(igraph,V)
importFrom(igraph,add.edges)
importFrom(igraph,add_edges)
importFrom(igraph,as.directed)
importFrom(igraph,as.undirected)
importFrom(igraph,decompose.graph)
importFrom(igraph,bfs)
importFrom(igraph,decompose)
importFrom(igraph,degree)
importFrom(igraph,delete.vertices)
importFrom(igraph,delete_vertices)
importFrom(igraph,dfs)
importFrom(igraph,diameter)
importFrom(igraph,get.diameter)
importFrom(igraph,get.shortest.paths)
importFrom(igraph,get.vertex.attribute)
importFrom(igraph,graph.bfs)
importFrom(igraph,graph.dfs)
importFrom(igraph,graph.empty)
importFrom(igraph,is.connected)
importFrom(igraph,is.directed)
importFrom(igraph,distances)
importFrom(igraph,get_diameter)
importFrom(igraph,is_connected)
importFrom(igraph,is_directed)
importFrom(igraph,make_empty_graph)
importFrom(igraph,neighborhood)
importFrom(igraph,shortest.paths)
importFrom(igraph,shortest_paths)
importFrom(igraph,vcount)
importFrom(igraph,vertex_attr)
importFrom(methods,is)
importFrom(nabor,knn)
importFrom(nat.utils,RunCmdForNewerInput)
Expand Down
Loading