Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AcmStream.Convert throws NullReferenceException when disposed #1108

Closed
lostmsu opened this issue Jan 21, 2024 · 1 comment
Closed

AcmStream.Convert throws NullReferenceException when disposed #1108

lostmsu opened this issue Jan 21, 2024 · 1 comment

Comments

@lostmsu
Copy link
Contributor

lostmsu commented Jan 21, 2024

Should throw something meaningful like ObjectDisposedException.

The issue happens because streamHeader field gets nulled in Dispose.
markheath added a commit that referenced this issue Feb 13, 2024
@markheath
better exception on disposed AcmStream.Convert #1108
5a9139c
@lostmsu
Copy link
Contributor Author

lostmsu commented Feb 13, 2024 •
edited
Loading

@markheath nitpick, but the first parameter to ObjectDisposedException constructor is objectName (e.g. nameof(AcmStream)), not message, and it should not be localized. Might be useful when figuring out between multiple disposed objects.

SMSapereAude pushed a commit to SMSapereAude/NAudio that referenced this issue Mar 18, 2024
@markheath @SMSapereAude
better exception on disposed AcmStream.Convert naudio#1108
3d76421
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@markheath @lostmsu