Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add specific params for remaining data subscriptions and requests #2094

Merged
merged 1 commit into from
Dec 8, 2024

Conversation

faysou
Copy link
Collaborator

@faysou faysou commented Dec 8, 2024

Pull Request

Add params for remaining previously non covered methods: subscribe, unsubscribe and request

Type of change

Delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)

How has this change been tested?

Existing tests

@faysou faysou force-pushed the extra-params-signatures branch 3 times, most recently from bb80ac7 to fa48444 Compare December 8, 2024 19:50
@faysou faysou force-pushed the extra-params-signatures branch from fa48444 to 9663aa2 Compare December 8, 2024 20:47
Copy link

codspeed-hq bot commented Dec 8, 2024

CodSpeed Performance Report

Merging #2094 will not alter performance

Comparing faysou:extra-params-signatures (9663aa2) with develop (67e132f)

Summary

✅ 52 untouched benchmarks

@cjdsellers cjdsellers merged commit ab4e460 into nautechsystems:develop Dec 8, 2024
11 checks passed
@faysou faysou deleted the extra-params-signatures branch December 17, 2024 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants