Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refine subscribe and unsubscribe for Bybit #2105

Merged
merged 1 commit into from
Dec 13, 2024
Merged

Refine subscribe and unsubscribe for Bybit #2105

merged 1 commit into from
Dec 13, 2024

Conversation

sunlei
Copy link
Collaborator

@sunlei sunlei commented Dec 13, 2024

Pull Request

Refine subscribe and unsubscribe for Bybit.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Dec 13, 2024

CodSpeed Performance Report

Merging #2105 will degrade performances by 38.4%

Comparing sunlei:sunlei/bybit-refine-ws-subscribe (510a526) with develop (ab0fa18)

Summary

❌ 1 regressions
✅ 51 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark develop sunlei:sunlei/bybit-refine-ws-subscribe Change
❌ test_is_limit_filled 17 µs 27.6 µs -38.4%

@sunlei
Copy link
Collaborator Author

sunlei commented Dec 13, 2024

@cjdsellers
Please try re-running the failed job. Thank you!

@cjdsellers cjdsellers merged commit 9103127 into nautechsystems:develop Dec 13, 2024
11 checks passed
@sunlei sunlei deleted the sunlei/bybit-refine-ws-subscribe branch December 13, 2024 11:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sunlei @cjdsellers