Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GraqhQL Inventory: Add ability for users to specify non-foreign key relationships with Null/None #123

Merged
merged 8 commits into from
Mar 30, 2022
Merged

GraqhQL Inventory: Add ability for users to specify non-foreign key relationships with Null/None #123

merged 8 commits into from
Mar 30, 2022

Conversation

FragmentedPacket
Copy link
Contributor

@FragmentedPacket FragmentedPacket commented Mar 11, 2022 •
edited
Loading

  • Add Python filter plugin to be re-used within gql_inventory plugin to construct GraphQL string from a Python dictionary
  • Remove Jinja templates that we were relying on previously

Fixes #122

TODO:

  • Create Tests
  • Update plugin documentation

@FragmentedPacket
Moved GraphQL query construction into a Python function (filter plugi…
d5a1fdc 
…n). Add ability to add filters at every level.
jvanderaa
jvanderaa previously approved these changes Mar 11, 2022
View reviewed changes
@ubajze
Copy link
Contributor

ubajze commented Mar 22, 2022

This PR closes issue #122, right?

@FragmentedPacket
Copy link
Contributor Author

This PR closes issue #122, right?

Correct. I just tied them together. I will complete the docs and tests this week and get it cleaned up. We're still waiting on the client to test as well, but may just push this in and cut a release.

@nniehoff
Copy link

@ubajze can we get the CI tests to pass here so we can fix #122

@FragmentedPacket
Copy link
Contributor Author

@ubajze can we get the CI tests to pass here so we can fix #122

I will get tests passing as well as finish documentation and tests this morning.

@ubajze
Copy link
Contributor

ubajze commented Mar 25, 2022

@FragmentedPacket thx

nniehoff
nniehoff previously approved these changes Mar 28, 2022
View reviewed changes
joewesch
joewesch reviewed Mar 28, 2022
View reviewed changes
plugins/inventory/gql_inventory.py Outdated Show resolved Hide resolved
plugins/filter/graphql.py Show resolved Hide resolved
plugins/inventory/gql_inventory.py Outdated Show resolved Hide resolved
FragmentedPacket and others added 5 commits March 28, 2022 16:47
@FragmentedPacket FragmentedPacket merged commit b5d98c7 into develop Mar 30, 2022
@FragmentedPacket FragmentedPacket deleted the gql-single branch March 30, 2022 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joewesch joewesch joewesch left review comments

@jvanderaa jvanderaa jvanderaa approved these changes

@nniehoff nniehoff nniehoff left review comments

@jmcgill298 jmcgill298 Awaiting requested review from jmcgill298 jmcgill298 is a code owner

@ubajze ubajze Awaiting requested review from ubajze

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unable to get device config_context using the the gql_inventory plugin
5 participants
@FragmentedPacket @ubajze @nniehoff @joewesch @jvanderaa