Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for Nautobot REST API versioning #139

Merged
merged 25 commits into from
Aug 24, 2022
Merged

Add support for Nautobot REST API versioning #139

merged 25 commits into from
Aug 24, 2022

Conversation

timizuoebideri1
Copy link
Contributor

No description provided.

@timizuoebideri1 timizuoebideri1 marked this pull request as draft April 24, 2022 19:33
@bryanculver bryanculver linked an issue Apr 25, 2022 that may be closed by this pull request
Add support for Nautobot REST API versioning in nautobot-ansible #126
Closed
@timizuoebideri1 timizuoebideri1 marked this pull request as ready for review May 3, 2022 13:02
@timizuoebideri1 timizuoebideri1 force-pushed the timizuo-feat-versioning branch 3 times, most recently from 253b430 to 4405f6f Compare May 4, 2022 17:54
@timizuoebideri1 timizuoebideri1 force-pushed the timizuo-feat-versioning branch from 4405f6f to c347c0c Compare May 4, 2022 18:17
jvanderaa
jvanderaa reviewed May 12, 2022
View reviewed changes
plugins/lookup/lookup.py Outdated Show resolved Hide resolved
briddo
briddo previously requested changes May 24, 2022
View reviewed changes
Copy link

@briddo briddo left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think all instances of the word "Api" should be "API" but apart from that (and my comment regarding the extra ) and the other reviewer's comments) this LGTM...

briddo
briddo reviewed May 24, 2022
View reviewed changes
plugins/lookup/lookup.py Outdated Show resolved Hide resolved
jvanderaa
jvanderaa requested changes Jun 18, 2022
View reviewed changes
Copy link
Contributor

@jvanderaa jvanderaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add version_added: "4.0.1" for the representative items.

plugins/lookup/lookup.py Show resolved Hide resolved
plugins/modules/aggregate.py Show resolved Hide resolved
plugins/modules/cable.py Show resolved Hide resolved
plugins/modules/circuit.py Show resolved Hide resolved
plugins/modules/circuit_termination.py Show resolved Hide resolved
plugins/modules/circuit_type.py Show resolved Hide resolved
jvanderaa
jvanderaa requested changes Jun 22, 2022
View reviewed changes
Copy link
Contributor

@jvanderaa jvanderaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor change and I'm good by it

.gitignore Outdated Show resolved Hide resolved
@timizuoebideri1 @jvanderaa
Update .gitignore
2f43878 
Co-authored-by: Josh VanDeraa <jv@networktocode.com>
jvanderaa
jvanderaa previously approved these changes Jun 24, 2022
View reviewed changes
@FragmentedPacket FragmentedPacket dismissed briddo’s stale review August 24, 2022 16:12

Seems to be resolved by Tim

@FragmentedPacket FragmentedPacket merged commit 77608d0 into develop Aug 24, 2022
@FragmentedPacket FragmentedPacket deleted the timizuo-feat-versioning branch August 24, 2022 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bryanculver bryanculver bryanculver left review comments

@FragmentedPacket FragmentedPacket FragmentedPacket approved these changes

@jmcgill298 jmcgill298 Awaiting requested review from jmcgill298 jmcgill298 is a code owner

@briddo briddo Awaiting requested review from briddo

@jvanderaa jvanderaa Awaiting requested review from jvanderaa jvanderaa is a code owner

@joewesch joewesch Awaiting requested review from joewesch joewesch is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add support for Nautobot REST API versioning in nautobot-ansible
5 participants
@timizuoebideri1 @bryanculver @briddo @jvanderaa @FragmentedPacket